refactor: align create-expert e2e tests with shared utilities#561
Merged
refactor: align create-expert e2e tests with shared utilities#561
Conversation
- Use withEventParsing from runner.ts instead of raw parseEvents - Add delegation verification (stopRunByDelegate events) - Add JSDoc header comment matching other e2e test conventions - Increase timeout to 180s for delegation round-trips - Move createTempDir to module scope - Add create-expert section to e2e/README.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5a14e7e to
9ee054e
Compare
…ation - Add createExpert callback and MCP tool to skill-management for dynamically creating expert definitions in memory - Implement createExpert in SkillManager.fromExpert to parse and store experts in the experts map - Update runtime to pass dynamically created experts to delegation executor - Update create-expert perstack.toml to use createExpert + addDelegate workflow instead of runExpert subprocess - Remove create-expert-skill dependency from create-expert config - Add unit tests for createExpert in skill-management and skill-manager Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9ee054e to
8a9a0b4
Compare
This was referenced Feb 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withEventParsingfromrunner.tsinstead of rawparseEventsfor event parsingstopRunByDelegateevents) to confirm the createExpert + addDelegate + delegate workflowcreate-expert/section toe2e/README.mdTest plan
pnpm typecheckpassespnpm biome check --writepassespnpm test:e2e -- create-expert.test.ts(requires API keys)🤖 Generated with Claude Code